“Ensuring code quality” and pretentious approvals are a boring way to think about PRs and code review on an team. Here are more fun things that I love about pull requests
https://abs.twimg.com/emoji/v2/... draggable="false" alt="🧵" title="Thread" aria-label="Emoji: Thread">
https://abs.twimg.com/emoji/v2/... draggable="false" alt="👉" title="Right pointing backhand index" aria-label="Emoji: Right pointing backhand index">
A pull request is an opportunity to LEARN
https://abs.twimg.com/emoji/v2/... draggable="false" alt="🤓" title="Nerd face" aria-label="Emoji: Nerd face"> Reviewing other people’s code can let you pick up language features you didn’t know about, introduce you to different parts of the system, or unveil business logic you haven’t bumped into yet.
A pull request is an opportunity to TEACH
https://abs.twimg.com/emoji/v2/... draggable="false" alt="💁🏽♂️" title="Man tipping hand (medium skin tone)" aria-label="Emoji: Man tipping hand (medium skin tone)"> Commiting code for someone else to review is an awesome way to demonstrate something you recently learnt. Bonus points for writing helpful explanations and sharing useful links in PR comments!
A pull request is an opportunity to COLLABORATE
https://abs.twimg.com/emoji/v2/... draggable="false" alt="🐜" title="Ant" aria-label="Emoji: Ant"> Why solve problems alone when you can be faster and smarter together?! Collaboration though discussions on a PR can sometimes be pretty close to pair programming, just a bit more asynchronous.
A pull request is an opportunity to SHARE OWNERSHIP
https://abs.twimg.com/emoji/v2/... draggable="false" alt="⚡️" title="High voltage sign" aria-label="Emoji: High voltage sign"> Even a swift glance over small changes means more than one person was involved. Over time that can contribute to developers feeling responsible for larger parts of the code base.
A pull request is an opportunity to PRAISE
https://abs.twimg.com/emoji/v2/... draggable="false" alt="🎉" title="Party popper" aria-label="Emoji: Party popper"> Reviewing a PR is perfect for giving positive feedback to co-workers on something *specific* and to demonstrate that someone cares about the work they have done. Sprinkle those comments with kudos and emoji.
A pull request is an opportunity for COMMUNICATION
https://abs.twimg.com/emoji/v2/... draggable="false" alt="💬" title="Speech balloon" aria-label="Emoji: Speech balloon"> Sometimes I have an idea, with no clue if I’m on the right track. But instead of churning out essays to ask in chat, I can comunicate way more efficiently with code: “Will changing this line do the thing?”
A pull request is an opportunity to KNOW YOUR TEAM MATES
https://abs.twimg.com/emoji/v2/... draggable="false" alt="🦸🏻♀️" title="Woman superhero (light skin tone)" aria-label="Emoji: Woman superhero (light skin tone)"> Build deep understanding of each others competance. Who on my team will think something *different* than me about this issue? A PR last week creates a base to bounce off new improvements this week.