man, i have so many problems with this https://twitter.com/skamille/status/1198060881168535552

i'm a senior-ish engineer and i dont need code review any less than i did when i started. i still write bugs! i _especially_ need people to check that my code isnt too "clever"! and the process of _writing_ a pull request, before its even reviewed, is a useful check

i think part of one's job as an engineering manager is monitoring that your code review is productive -- that seniors aren't just steamrolling their PRs over juniors, that the comments aren't just, like, artisanal linting

its frustrating how little effort we put in this industry towards learning and practicing *processes* that aren't just technologies. if you tell anyone they're doing code review "wrong" that's ~nO tRuE sCoTsMan~

and the idea that code review is hampering productivity is just baffling because -- maybe this is different for you, but i've never worked anywhere where the biggest problem was that we weren't producing code fast enough

the problem I usually have as an engineer is that we built the *wrong* thing. At a micro level, this could be a React component that has props that are awkward to work with. At a macro level, this could be an end-to-end feature that nobody needs

you would think that code review would only catch the former problems, but i've spent the last two weeks working on permissions because I discovered a macro-scale misunderstanding while reviewing the code for the first PR in a project that was doomed to go off the rails

this is a good subthread https://twitter.com/haley/status/1198131252064178176

Another good thread from, uh, the previous time Camille kicked this hornet's nest https://twitter.com/hillelogram/status/1170864979924455426

this is an important point, and a lot of the bugs ive found or created in code review were spotted in manual QA, and then _diagnosed_ in the code https://twitter.com/deech/status/1198262357123911680?s=21

On the Glitch community team, every PR includes a link to a remix of the site; a lot of open source projects in the React world have mandatory codesandbox examples for PRs and issues. Removing the friction around QA is incredibly useful for user interface work